Added section on features and limitations, with example yaml files. by bsteciuk · Pull Request #1 · JMesser81/kubernetes.github.io

bsteciuk · 2017-12-01T02:59:02Z

Added some info on features and limitations, mentioned kubeadm support, some other cosmetic changes.

Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>

Update index.md

JMesser81 · 2017-12-04T06:34:54Z

docs/getting-started-guides/windows/index.md

+- Support for kubeadm commands to add Windows Server nodes to a Kubernetes environment

- The Kubernetes control plane (API Server, Scheduler, Controller Manager, etc) continue to run on Linux, while the kubelet and kube-proxy can be run on Windows Server version 1709.
+The Kubernetes control plane (API Server, Scheduler, Controller Manager, etc) continue to run on Linux, while the kubelet and kube-proxy can be run on Windows Server 2016 or later


Are we say WS2016 due to the fact that OVS/OVN only require this version of the platform? Or, that initial support will continue to work on WS106?

I'm worried that this will confuse the message above about new platform support with Windows Server version 1709.

OVS/OVN requires Windows Server 2016 or later, that means it also works with Windows Server version 1709.
As far as I know the initial support is still there and should continue working, but @bsteciuk might be a better person to ask for this.

@JMesser81 we will continue to support customers that don't want to take a dependency on 1709. we will however stress that 1709 offers significant benefits and that's our recommendation for OS release

JMesser81 · 2017-12-04T06:47:14Z

docs/getting-started-guides/windows/index.md

+**Note:** Windows Server Containers on Kubernetes is a Beta feature in Kubernetes v1.9
+
+## Build
+We recommend using the release binaries that can be found at [https://github.com/kubernetes/kubernetes/releases](https://github.com/kubernetes/kubernetes/releases).


From Microsoft perspective, we would like to encourage people to create a Linux cluster and then add Windows nodes to the existing cluster. Perhaps this isn't necessary now that it sounds as though kubeadm integration works with Windows as well. Question: will kubeadm work with any CNI plugin on Windows?

Usually when people come here it means they already have a Linux cluster and they have a Windows node. I don't think it's even possible to have the all the kubernetes services running on Windows. @bsteciuk can you answer about the question for kubeadm? Thanks!

I will let @bsteciuk chime in as well, but @JMesser81 , kubeadm will add the node to your cluster and then you have to explicitly run the commands to set up the CNI

With kubeadm, the steps would be

Initialize the master with kubeadm (Linux)

Setup CNI based networking (outside of kubeadm)

Join worker nodes to cluster with kubeadm (Linux or Windows)

@bsteciuk this is great info. i think we should have it here in the docs as well. cna you please update the PR with this as well?

JMesser81 · 2017-12-04T06:57:34Z

docs/getting-started-guides/windows/index.md

+## Build
+We recommend using the release binaries that can be found at [https://github.com/kubernetes/kubernetes/releases](https://github.com/kubernetes/kubernetes/releases).
+
+If you wish to build the code yourself, please follow the next instructions:


We intend to have these instructions included on our MSDN docs page. Those instructions are currently staged here: https://github.com/gkudra-msft/Virtualization-Documentation/blob/kubernetes-docs/virtualization/windowscontainers/kubernetes/compiling-kubernetes-binaries.md

My intent is to have the contents from this PR show up on K8s doc site - Getting Started Guide - and then have links to our MSDN docs for more detailed information such as how to build the binaries. Any concerns?

If you're referring to to https://github.com/Microsoft/SDN/blob/master/Kubernetes/HOWTO-on-prem.md which was before as MSDN docs, I don't think that's really ok in my opinion.
I mentioned some reasons in the original PR: https://github.com/kubernetes/website/pull/6180/files#r153472849
And besides that you are referencing a master branch of a github repository, there should be at least a different branch.
Any reason not to have those few lines on how to build the code here and to have them somewhere else?

i prefer to keep a single source of truth on how to build K8s for windows in this page. this is a kubernetes docs page after all and we should not be referencing outside if we can avoid it

JMesser81 · 2017-12-04T07:02:04Z

docs/getting-started-guides/windows/index.md


 #### Host-Gateway Topology
-This topology is similar to the Upstream L3 Routing topology with the only difference being that static IP routes are configured directly on each cluster node and not in the upstream ToR. Each node uses a local 'l2bridge' network with a Pod CIDR assigned as before and has routing table entries for all other Pod CIDR subnets assigned to the remote cluster nodes.
+This topology is similar to the Upstream L3 Routing topology with the only difference being that static IP routes are configured directly on each cluster node and not in the upstream ToR. Each node uses a local 'l2bridge' network with a pod CIDR assigned as before and has routing table entries for all other pod CIDR subnets assigned to the remote cluster nodes.


Similar to above, I'll add a link to this page for more detailed instructions:

https://github.com/gkudra-msft/Virtualization-Documentation/blob/kubernetes-docs/virtualization/windowscontainers/kubernetes/configuring-host-gateway-mode.md

The only thing that @bsteciuk modified here was pod to Pod in order to address this comment: https://github.com/kubernetes/website/pull/6180/files#r148899310
But the link you want to add it's a fork of the original repo. I would rather post the link from the original repo at least, the fork might be deleted at some point but the main repo should still be there.

Yes, we will be merging today to the master repo

JMesser81 · 2017-12-04T07:03:10Z

docs/getting-started-guides/windows/index.md


 1. Linux hosts should be setup according to their respective distro documentation and the requirements of the Kubernetes version you will be using. 
-2. Configure Linux Master node using steps [here](https://github.com/Microsoft/SDN/blob/master/Kubernetes/HOWTO-on-prem.md)
+2. Configure Linux Master node using steps [here](https://github.com/Microsoft/SDN/blob/master/Kubernetes/HOWTO-on-prem.md#prepare-the-master)


Will update link to be here: https://github.com/gkudra-msft/Virtualization-Documentation/blob/kubernetes-docs/virtualization/windowscontainers/kubernetes/creating-a-linux-master.md

Similar to above, I would like to see the changes here rather than on a fork: https://github.com/MicrosoftDocs/Virtualization-Documentation

i agree with @alinbalutoiu if by here he means to include the docs in this page and not reference something outside

In my opinion since this is the official documentation, it should point to its internals i.e.: https://kubernetes.io/docs/getting-started-guides/scratch/ .

Yes, we will be merging the forked changes to original repo

bsteciuk force-pushed the WSv1709NetUpdates branch from 212a327 to c021988 Compare December 1, 2017 16:31

bsteciuk and others added 2 commits December 1, 2017 12:08

Added section on features and limitations, with example yaml files.

a88e70c

Update index.md

4468bda

bsteciuk force-pushed the WSv1709NetUpdates branch from c021988 to 4468bda Compare December 1, 2017 17:13

bsteciuk added 2 commits December 1, 2017 13:25

Added kubeadm section, few other small fixes

ffd6057

Few minor grammar fixes

3e5c06d

bsteciuk mentioned this pull request Dec 1, 2017

Updates for Windows Server version 1709 with K8s v1.8 kubernetes/website#6180

Merged

bsteciuk and others added 4 commits December 1, 2017 16:52

Addressed a number of issues brought up against the base PR

3308735

Fixed windows-host-setup link

5d89b14

Update index.md

ee8801d

Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>

Merge pull request #2 from alinbalutoiu/WSv1709NetUpdates_updated

3585405

Update index.md

JMesser81 reviewed Dec 4, 2017

View reviewed changes

michmike added 2 commits December 4, 2017 02:54

Update index.md

ed832e3

Update index.md

ae44007

JMesser81 merged commit 95638a2 into JMesser81:WSv1709NetUpdates Dec 4, 2017

Conversation

bsteciuk commented Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinbalutoiu Dec 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michmike Dec 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bsteciuk commented Dec 1, 2017 •

edited

Loading

alinbalutoiu Dec 4, 2017 •

edited

Loading

michmike Dec 4, 2017 •

edited

Loading