Skip to content

Optimise extract_meshlet_meshes and prepare_meshlet_per_frame_resources#17

Merged
JMS55 merged 3 commits intoJMS55:meshletfrom
ricky26:meshlet
Jan 12, 2024
Merged

Optimise extract_meshlet_meshes and prepare_meshlet_per_frame_resources#17
JMS55 merged 3 commits intoJMS55:meshletfrom
ricky26:meshlet

Conversation

@ricky26
Copy link
Copy Markdown

@ricky26 ricky26 commented Jan 12, 2024

Objective

  • In extract_meshlet_meshes there is a tight loop which performs badly
  • In prepare_meshlet_per_frame_resources several redundant memory copies happen

Solution

  • In extract_meshlet_meshes, replace the loop with several extend() calls, which will improve locality and reduce number of capacity checks
  • In prepare_meshlet_per_frame_resources copy directly from the Pod-compatible storage buffers into GPU memory

@github-actions
Copy link
Copy Markdown

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@JMS55 JMS55 merged commit 3f403bb into JMS55:meshlet Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants