Fix Lagrange Coefficient Key Mismatch in CPabe_BSW07.decrypt#323
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Apr 27, 2025
Komorebi-Z:dev
Merged
Fix Lagrange Coefficient Key Mismatch in CPabe_BSW07.decrypt#323jakinyele merged 1 commit intoJHUISI:devfrom Komorebi-Z:dev
jakinyele merged 1 commit intoJHUISI:devfrom
Komorebi-Z:dev
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During use, we discovered that the
decryptmethod in theCPabe_BSW07class wasn’t executing correctly, throwing the error:After investigation, we traced the problem to the
_getCoefficientsDictfunction in charm/toolbox/secretutil.py, which wasn’t producing the correct Lagrange coefficients. Although_getCoefficientsDictcallsrecoverCoefficients, the keys in itsthis_coeffdictionary didn’t match the logic expected byrecoverCoefficients. We’ve made a small adjustment torecoverCoefficientsto align the keys and fix the bug.