Fix for #303 and some additional issues with PY_SSIZE_T_CLEAN macro#305
Merged
jakinyele merged 7 commits intoJHUISI:devfrom Apr 10, 2024
Merged
Fix for #303 and some additional issues with PY_SSIZE_T_CLEAN macro#305jakinyele merged 7 commits intoJHUISI:devfrom
jakinyele merged 7 commits intoJHUISI:devfrom
Conversation
…10, resulting in an error when using C extension modules. Need to explicitly define it. See https://docs.python.org/3.10/c-api/arg.html#strings-and-buffers
…tialization of integer failed without raising an exception'
… 3.10. Changed from int to Py_ssize_t for some variables after the macro definition, or the cipher mode would always set to zero somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the fix for #303, I got more test errors with the familiar message "PY_SSIZE_T_CLEAN macro must be defined for '#' formats". After adding the macro definition to AES.c, some of the tests failed with the message "Unknown cipher feedback mode 0", when the expected mode should be 1 to 6. It turned out that the data type for mode should be long int or something similar instead of int. So I make additional fixes.
Tested OK for Python versions 3.8 to 3.10 on Ubuntu, WSL, and Ubuntu on Raspberry Pi.