Merged
Conversation
…10, resulting in an error when using C extension modules. Need to explicitly define it. See https://docs.python.org/3.10/c-api/arg.html#strings-and-buffers
…tialization of integer failed without raising an exception'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue seems to be with the definition for
PyMethodDef Integer_methods[]in integermodule.c. Somehow Python versions 3.8 and above do not like specifyingMETH_O | METH_NOARGSin the method testCoPrime. With this, when trying to finalise the type object throughPyType_Ready(&IntegerType), it always returns a negative status code and fails silently.A solution is to replace either
METH_NOARGSorMETH_Oinstead of the above. I also notice that no other file is using the methodtestCoPrime.I have tested Python 3.7, 3.8, 3.9, and 3.10 on Ubuntu 22.04 WSL for Windows 11, Ubuntu 22.04 on Raspberry Pi, and Ubuntu 20.04. All worked except for Python 3.10 on Ubuntu 20.04, but the issue was with an outdated pip.