Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#220
Added the fixes I came up with to compile the Charm module with a Relic backend for pairing.
For the functions that had name conflicts with existing functions in Relic, I added
charm_as a prefix. I also added this to theg#_write_strfunctions even though they had no name conflict in order to keep a consistent naming convention for those families of functions.I tested by generating random G1, G2, GT, ZR points on the BN254 curve in Python and making sure all expected arithmetic worked and the pairing function worked. If there are additional things I should check, please let me know.