Fix downcaseTokens issue in policytree.py with pyparsing >=2.4.1#252
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Aug 4, 2020
Merged
Fix downcaseTokens issue in policytree.py with pyparsing >=2.4.1#252jakinyele merged 1 commit intoJHUISI:devfrom
jakinyele merged 1 commit intoJHUISI:devfrom
Conversation
In [Pyparsing 2.4.1](https://github.com/pyparsing/pyparsing/releases/tag/pyparsing_2.4.1), `downcaseTokens` is moved to `pyparsing_common`, breaking imports in policytree.py. An alternative fix is to update policytree.py to use the `pyparsing_common.downcaseTokens` import, but that might involve a permanent bump to the pyparsing version (which is the correct fix, but less conservative).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Pyparsing 2.4.1,
downcaseTokensis moved topyparsing_common, breaking imports in policytree.py.An alternative fix is to update policytree.py to use the
pyparsing_common.downcaseTokensimport, but that might involve a permanent bump to the pyparsing version (which is the correct fix, but less conservative).fixes #249