Add instructions for newer Python versions#237
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Nov 21, 2019
fwdekker:dev
Merged
Add instructions for newer Python versions#237jakinyele merged 1 commit intoJHUISI:devfrom fwdekker:dev
jakinyele merged 1 commit intoJHUISI:devfrom
fwdekker:dev
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the installation instructions to explain how to use newer Python versions. The implementation already works with these newer versions; only
Dockerfileandconfigure.shhad to be updated slightly.I have tested the updated code in a Ubuntu VM and in a Ubuntu container and some sample code works as intended.
I noted that some files still implicitly assume that Python 3.2 is being used, but that would require a larger refactor to get it to work with arbitrary Python versions. These files are not part of Charm itself but rather of the installation process. These files are as follows:
installers/osx.installer/build-osx-installer.shinstallers/osx.installer/Charm Crypto.pkgprojinstallers/win.installer/charm-exe-script.nsi