Use math.gcd instead of fractions.gcd#226
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Jul 18, 2019
Merged
Conversation
Member
|
@lenerd How about support for py3.4 or below? math.gcd is not available. Please add a check to import |
The function fractions.gcd is deprecated since Python 3.5 and math.gcd
should be used instead. This imports the new math.gcd if available, and
fixes the following warning:
DeprecationWarning: fractions.gcd() is deprecated. Use math.gcd()
instead.
Contributor
Author
|
Should have thought about this, sorry ... I have added guards for the imports. Note that the recently released version 5.0 of pytest only supports Python 3.5 and newer. Tu run tests in a virtual environment with an older Python version, I had to specify |
jakinyele
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
while running the charm test I got the following warning (see also Python documentation):
This PR makes the according changes to use
math.gcd.