Prevent trivial hash collisions - fixes #201#212
Merged
jakinyele merged 1 commit intoJHUISI:devfrom Apr 10, 2019
timothymctim:issue-201
Merged
Prevent trivial hash collisions - fixes #201#212jakinyele merged 1 commit intoJHUISI:devfrom timothymctim:issue-201
jakinyele merged 1 commit intoJHUISI:devfrom
timothymctim:issue-201
Conversation
Merged
Tuples are hashed in a way similar to the TupleHash algorithm defined in [NIST SP 800-185](https://doi.org/10.6028/NIST.SP.800-185).
timothymctim
commented
Mar 31, 2019
| print("unexpected type: ", type(i)) | ||
| # consider other types | ||
| #print("s => %s" % s) | ||
| assert len(s) != 0, "hash input is empty." |
Contributor
Author
There was a problem hiding this comment.
This assertion doesn’t exists anymore in the new code. Now group.hash('') == group.hash(tuple()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuples are hashed in a way similar to the TupleHash algorithm defined in NIST SP 800-185.