Merged
Conversation
This way it is possible to set the MAX_SIZE maximum message size from classes derived from Protocol class, if necessary. Signed-off-by: Gabor Szekely <szvgabor@gmail.com>
b64decode can take both str and bytes objects as well, and the deserialize function in the Protocol class calls this function with a bytes object Signed-off-by: Gabor Szekely <szvgabor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm trying to create a protocol with charm, and ran into some problems.
The recv_msg function in the Protocol class wasn't working, because unpickleObject didn't allow bytes objects. The other problem was that my messages were getting truncated at 2048, because of MAX_SIZE, and there was no way to tweak this variable from the child class since it was not part of the Protocol class.