Skip to content

[bug 135] Fix compilation errors with OpenSSL 1.1.0 caused by API change#141

Merged
jakinyele merged 1 commit intoJHUISI:devfrom
ElectroSuccess:dev
Jul 11, 2017
Merged

[bug 135] Fix compilation errors with OpenSSL 1.1.0 caused by API change#141
jakinyele merged 1 commit intoJHUISI:devfrom
ElectroSuccess:dev

Conversation

@ElectroSuccess
Copy link
Copy Markdown

The PR changes conversions between OpenSSL Big Numbers, PyLongObjects and MPZ integers. Low level bytes operations which highly depend on internal structures form have been changed to API function calls. This change is justified by the following reasons:

  • With OpenSSL 1.1.0, API has changed, no longer allowing for low level operations on Big Numbers. This change caused compilation errors. The PR uses API function calls suggested by OpenSSL manual.
  • While the solution may cause a small performance overhead, it is safer as it does not depend on memory structures which potentially may change in the future.

Additionaly, removed BN_init function has been replaced with BN_new, as suggested by the current OpenSSL manual.

@ElectroSuccess
Copy link
Copy Markdown
Author

This PR addresses #135.

@jakinyele jakinyele merged commit 3141de4 into JHUISI:dev Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants