Feature/split tests#115
Merged
jakinyele merged 5 commits intoJHUISI:devfrom Aug 25, 2016
dennisschroer:feature/split-tests
Merged
Feature/split tests#115jakinyele merged 5 commits intoJHUISI:devfrom dennisschroer:feature/split-tests
jakinyele merged 5 commits intoJHUISI:devfrom
dennisschroer:feature/split-tests
Conversation
# Conflicts: # charm/test/schemes/ibenc_test.py
Contributor
Author
|
Hmm, it fails here, but here it is successful. I don't know what goes wrong, but maybe a rerun of the tests helps... |
Member
|
@denniss17 Thanks! Will add some additional error handling to the tests. That should help. When you get a chance, do you mind submitting a PR for 2.7-dev? Also, do you have any thoughts on how we could merge the 2.7-dev and dev branches? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I did earlier, I splitted the tests for ABE and IBE schemes in separate files to make it more clearer.