Feature/Travis CI configuration#104
Merged
jakinyele merged 4 commits intoJHUISI:devfrom Jun 21, 2016
dennisschroer:feature/travis-ci
Merged
Feature/Travis CI configuration#104jakinyele merged 4 commits intoJHUISI:devfrom dennisschroer:feature/travis-ci
jakinyele merged 4 commits intoJHUISI:devfrom
dennisschroer:feature/travis-ci
Conversation
Member
|
Thank you! |
Contributor
Author
|
Wow that was quick 👍 |
Member
|
This has been on my todo list for quite awhile. So, very much appreciated! |
Contributor
Author
|
I see that is not quite correct now, https://travis-ci.org/JHUISI/charm/builds/139206275 fails but travis says it is succesful. Let me see if I can fix that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR correctly sets up continuous integration with Travis by installing dependencies, building the application and executing the tests. It also adds build status to the README page.
Travis was already enabled (https://travis-ci.org/JHUISI/charm), but not correctly configured resulting in a build failure at all time (by default it attempts to test a ruby application). This also gives the (mostly) wrong indication that PRs are not correct.