[WIP] Make most boilerplate code auto-generated & refactor#67
Merged
[WIP] Make most boilerplate code auto-generated & refactor#67
Conversation
…old daq models will not work any more
…emented in Convert()
Collaborator
Author
|
It basically works now. I will merge it after I implement prelu in modelbuider |
…ow copies the data
b1ec65a to
98fca4e
Compare
98fca4e to
66f9a2b
Compare
…row exceptions on error
…the rule of three
2fa06a7 to
5aee023
Compare
8052b54 to
f64b511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old daq models will not work anymore.
With this PR, when adding new op, only code in
convert()in OnnxConvert.cpp will need to be updated.In this PR, dilated conv,
preluandglobal poolingdoesn't work