Skip to content

Xadd queues consumers can help producers#326

Merged
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:cooperative_xadd_poll
Nov 25, 2020
Merged

Xadd queues consumers can help producers#326
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:cooperative_xadd_poll

Conversation

@franz1981

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Oct 29, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 724

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.09%) to 86.127%

Files with Coverage Reduction New Missed Lines %
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java 1 79.91%
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMapLong.java 1 79.9%
jctools-core/src/main/java/org/jctools/maps/NonBlockingSetInt.java 1 77.09%
jctools-core/src/main/java/org/jctools/queues/MpmcUnboundedXaddArrayQueue.java 3 95.67%
jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java 7 76.06%
Totals Coverage Status
Change from base Build 722: 0.09%
Covered Lines: 4799
Relevant Lines: 5572

💛 - Coveralls

@franz1981

Copy link
Copy Markdown
Collaborator Author

@nitsanw I've yet to decide if relaxedXXX makes sense will do this too (especially for the mpsc variant)

@franz1981

franz1981 commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator Author

This one should be code completed: probably is time for me to fix the generator to create the atomic variant

Comment thread jctools-core/src/main/java/org/jctools/queues/MpmcUnboundedXaddArrayQueue.java Outdated
@nitsanw

nitsanw commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

reading through it now

@franz1981 franz1981 force-pushed the cooperative_xadd_poll branch from 18cd5cf to 3c7af74 Compare November 23, 2020 08:45

@nitsanw nitsanw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please consider suggestions

Comment thread jctools-core/src/main/java/org/jctools/queues/MpmcUnboundedXaddArrayQueue.java Outdated
@franz1981 franz1981 force-pushed the cooperative_xadd_poll branch from 3c7af74 to f5d8bc9 Compare November 25, 2020 04:04
@nitsanw nitsanw merged commit dbd8594 into JCTools:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants