MpscBlockingConsumerArrayQueue.offerIfBelowThreshold()#314
Merged
Conversation
Pull Request Test Coverage Report for Build 693
💛 - Coveralls |
Contributor
|
Testing needs to be extended, see the method used for the same method on MpscArrayQueue. We also need to cover the scenarios around unparking the consumer here, which will require some refactoring to the extended cases I expect. |
Contributor
|
See suggested changes here: 9e2d882 |
nitsanw
reviewed
Aug 5, 2020
|
|
||
| final long available = (producerLimit - pIndex) >> 1; | ||
| // sizeEstimate <= size | ||
| final long sizeEstimate = capacity - available; |
Contributor
There was a problem hiding this comment.
This is a bug as capacity is actually 2xcapacity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add offerIfBelowThreshold() to MpscBlockingConsumerArrayQueue, with the same semantics as MpscArrayQueue.offerIfBelowThreshold().