Skip to content

xadd qs: cleaning up abstractions#283

Merged
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:xadd_cleaning
Jan 15, 2020
Merged

xadd qs: cleaning up abstractions#283
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:xadd_cleaning

Conversation

@franz1981

@franz1981 franz1981 commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@franz1981

franz1981 commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator Author

I've noticed that moveToNextConsumerChunk is using soConsumerChunk for single-consumer case too: TBH the perf difference should be negligible and I cannot say if it worths to address it

@coveralls

coveralls commented Jan 4, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 647

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 85.852%
Files with Coverage Reduction New Missed Lines %
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java 3 80.35%
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMapLong.java 3 79.65%
jctools-core/src/main/java/org/jctools/maps/NonBlockingSetInt.java 3 77.65%
jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java 5 75.56%
Totals Coverage Status
Change from base Build 646: 0.1%
Covered Lines: 4709
Relevant Lines: 5485
💛 - Coveralls

@nitsanw nitsanw merged commit aabd96a into JCTools:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@franz1981 @coveralls @nitsanw