Skip to content

mpmc xadd q poll docs + clearing up names#282

Merged
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:poll_blocked
Jan 3, 2020
Merged

mpmc xadd q poll docs + clearing up names#282
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:poll_blocked

Conversation

@franz1981

@franz1981 franz1981 commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@franz1981

franz1981 commented Jan 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@nitsanw I've tried to move the pooling of cChunk after this.soConsumerChunk(next), but we can't because this.soConsumerChunk(next) marks the end of the single-threaded code and freeChunksPool is spsc, so cannot be used by different producers: we would need an mpsc queue to perform that change

@coveralls

coveralls commented Jan 3, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 641

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 86.251%
Files with Coverage Reduction New Missed Lines %
jctools-core/src/main/java/org/jctools/queues/MpmcUnboundedXaddArrayQueue.java 1 93.97%
jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java 2 77.31%
Totals Coverage Status
Change from base Build 640: 0.3%
Covered Lines: 4730
Relevant Lines: 5484
💛 - Coveralls

@nitsanw nitsanw merged commit c6836e8 into JCTools:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@franz1981 @coveralls @nitsanw