mpmc xadd q poll wasn't handling correctly chunkSize = 1 pooled case#281
Merged
Conversation
Pull Request Test Coverage Report for Build 639
💛 - Coveralls |
519be84 to
615e536
Compare
nitsanw
reviewed
Jan 2, 2020
caca969 to
f97dd96
Compare
QueueSanityTest::testSize with chunkSize = 1 and 1 recycled chunks was failing with a blocked poll because it wasn't handling ccChunkIndex == ciChunkIndex as an isFirstElementOfNextChunk case
f97dd96 to
db86aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueueSanityTest::testSize with chunkSize = 1 and 1 recycled chunks was
failing with a blocked poll because it wasn't handling ccChunkIndex ==
ciChunkIndex as an isFirstElementOfNextChunk case