Skip to content

mpsc xadd q relaxedPeek cannot assume element presence#270

Merged
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:relaxed_peek
Nov 25, 2019
Merged

mpsc xadd q relaxedPeek cannot assume element presence#270
nitsanw merged 1 commit into
JCTools:masterfrom
franz1981:relaxed_peek

Conversation

@franz1981

@franz1981 franz1981 commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

Relaxed peek cannot assume immediate element presence on next due to consumerBuffer::next presence, because there are cases where the element is set after next (eg when the appending thread is the same that will set its first element)

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 582

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 85.384%

Files with Coverage Reduction New Missed Lines %
jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java 5 76.81%
jctools-core/src/main/java/org/jctools/maps/ConcurrentAutoTable.java 7 53.85%
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java 7 78.34%
Totals Coverage Status
Change from base Build 581: -0.1%
Covered Lines: 4767
Relevant Lines: 5583

💛 - Coveralls

@franz1981

Copy link
Copy Markdown
Collaborator Author

@nitsanw Despite what coveralls says, this is ready to be reviewed/merged

@nitsanw nitsanw merged commit 31752ec into JCTools:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants