MpscLinkedAtomicQueue API breakage#193
Merged
Merged
Conversation
Motivation: 4e68fd2 introduced a new code generation utility. However this commit removed the public constructor for MpscLinkedAtomicQueue because MpscLinkedQueue has a static factory method and a protected constructor. Modifications: - Restore the public constructor in MpscLinkedAtomicQueue Result: Original API restored for MpscLinkedAtomicQueue.
Contributor
Author
|
@nitsanw - PTAL. |
Contributor
|
Does this necessitate an urgent patch release for netty? |
|
@nitsanw this not affects netty... @Scottmitch your call for a release tho :) |
Contributor
Author
|
@nitsanw - Yes please for a release ... as @normanmaurer said I don't think this directly impacts Netty, but prevents updating for folks that use this queue. |
Contributor
|
will release over weekend |
Contributor
Author
|
@nitsanw - any updates on the release? |
Contributor
|
Sorry, running around like a headless chicken ATM... will get back to this when I return from current trip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
4e68fd2 introduced a new code generation utility. However this commit removed the public constructor for MpscLinkedAtomicQueue because MpscLinkedQueue has a static factory method and a protected constructor.
Modifications:
Result:
Original API restored for MpscLinkedAtomicQueue.