Skip to content

Add MET v12.0.0 and METplus v6.0.0#509

Merged
climbfuji merged 7 commits intoJCSDA:spack-stack-devfrom
climbfuji:feature/met12_metplus6
Feb 20, 2025
Merged

Add MET v12.0.0 and METplus v6.0.0#509
climbfuji merged 7 commits intoJCSDA:spack-stack-devfrom
climbfuji:feature/met12_metplus6

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jan 29, 2025

Description

This PR adds met@12.0.1 and metplus@6.0.0. Credits to @rickgrubin-noaa (cherry-picked add met@12 and metplus@6) for the original set of changes.

These new versions were tested by a NRL colleaguge using a spack-stack installation based on PR JCSDA/spack-stack#1481 on Nautilus.

@rickgrubin-noaa
Copy link
Copy Markdown
Collaborator

Should configs/templates/gsi-addon-dev/spack.yaml also be updated?

  packages:
      met:
         require:: '@9.1.3 +python +grib2'
      metplus:
         require:: '@3.1.1 ^met@9.1.3'

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Should configs/templates/gsi-addon-dev/spack.yaml also be updated?

  packages:
      met:
         require:: '@9.1.3 +python +grib2'
      metplus:
         require:: '@3.1.1 ^met@9.1.3'

@DavidHuber-NOAA ?

@DavidHuber-NOAA
Copy link
Copy Markdown
Collaborator

@rickgrubin-noaa No, the gsi-addon needs to stay at 3.1.1/9.1.3 until the global workflow updates to a newer verification system.

A slightly longer answer: the METplus API completely changed between version 3 and version 4, so our existing verification package would need a complete overhaul. There is a new verification system in operational GFS v16 called EVS, but it is not yet supported on any of the research platforms nor by the develop version of the global workflow. I am not sure when this will be brought into the global workflow, but it probably needs to be soon.

@climbfuji climbfuji marked this pull request as ready for review February 19, 2025 20:39
Comment on lines +38 to +49
depends_on("python@3.10.4:", when="@6.0.0", type=("run"))
depends_on("met@12:+python", when="@6.0.0", type=("run"))
depends_on("met+python", type=("run"))
# https://metplus.readthedocs.io/en/main_v6.0/Users_Guide/installation.html
depends_on("netcdf-c@1.5.4:", when="@6.0.0")
depends_on("netcdf-c")
depends_on("py-python-dateutil@2.8:", when="@6.0.0", type=("run"))
depends_on("py-python-dateutil", type=("run"))

depends_on("py-cartopy@0.20.3:", when="@6.0.0 +makeplots", type=("run"))
depends_on("py-cartopy", when="+makeplots", type=("run"))
depends_on("py-matplotlib@3.5.2", when="@6.0.0 +cycloneplotter", type=("run"))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not '@6:' for all of these, since I'm assuming it won't just be for the one release?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, let me change that

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Corresponding spack develop PR: spack#49120

@climbfuji climbfuji deleted the feature/met12_metplus6 branch February 20, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

5 participants