Skip to content

URL encoded whitespace is not supported #36

@richard-giraud

Description

@richard-giraud

Observed Behavior:
Attempting to parse the URLgit@host.xz:path%20to/repo%20name results in the following message:

Error: URL parsing failed.

Testing has shown that the issue is with the URL encoded whitespace (i.e.: %20).

Expected Behavior:
This should succeed.

Impact:
Valid URLs are incorrectly rejected.

Background:
I encountered this while working on an Azure DevOps (ADO) repository that has a space in its name. The ADO web UI provides the URL with the spaces URL encoded. So, when I do a git clone git@host.xz:path%20to/repo%20name the origin remote is set to git@host.xz:path%20to/repo%20name.

FLXBL, a Salesforce publishing tool, builds the git repository URL into its artifacts, then validates them using this library. It then fails because the URL fails to parse.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions