-
Notifications
You must be signed in to change notification settings - Fork 11
Release to preserve the state of the project prior to major refactoring #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce GetFullyQualifiedPocoName in CsHelpers class to return fully qualified POCO names. Update using directives to include AXSharp.Compiler.Cs.Helpers. Refactor Create methods in various builder classes to use GetFullyQualifiedPocoName. Update AddToSource method calls to use fully qualified POCO names. Modify CsPlainConstructorBuilder and CsPlainSourceBuilder to use GetFullyQualifiedPocoName. Wrap generated code in Pocos namespace in CsPlainSourceBuilder. Update AddCreatePocoMethod in CsOnlinerSourceBuilder to use GetFullyQualifiedPocoName. Adjust namespace and type declaration methods in CsPlainSourceBuilder to use GetFullyQualifiedPocoName.
Updated namespace references for Pocos classes across multiple files to use the global:: prefix. This change affects methods such as OnlineToPlainAsync, _OnlineToPlainNoacAsync, PlainToOnlineAsync, _PlainToOnlineNoacAsync, ShadowToPlainAsync, PlainToShadowAsync, DetectsAnyChangeAsync, and CreateEmptyPoco. The updates ensure the correct global namespace is used, avoiding potential conflicts and improving code maintainability.
Updated GitVersion.yml to set next-version to 0.20.0 and change mode for main branch. Increased segment sizes in WebApiConnector.cs. Modified AXSharp.Connector.S71500.WebAPITests.csproj to update package references and include new certificates. Replaced WebApiConnector instantiation with TestConnector.TestApiConnector in Exploratory.cs and WebApiConnectorTests.cs. Removed TestConnector class from WebApiPrimitiveTests.cs and added new using directives. Updated GH_PTKu_ix_56.cs, GH_PTKu_ix_59_68.cs, and GH_PTKu_ix_xx.cs to use TestConnector.SecurePlc. Updated apax.yml with new project name, version updates, environment variables, and scripts. Modified go.ps1 to set targetInput and update sld command. Updated Directory.Build.props to target net8.0. Added new TestConnector.cs for handling Web API connections and certificate validation.
…placed_into_onlinenamespace_Poco_instead_of_Poco_onlinenamespace
…d readability and consistency
Modified OnlinerBaseTypeTests.cs to use Is.InstanceOf for more accurate type checking in GetParentTest. Updated test_L10.ps1 and test_L2.ps1 scripts to run with --framework net9.0 and exit with $LASTEXITCODE for improved build and test processes.
Updated `dotnet run` command to use `--framework net9.0` in `dev.yml`, `master.yml`, `pr-dev.yml`, and `release.yml` to ensure the project runs with .NET 9.0. Removed the `Test Report` step using `dorny/test-reporter@v1` from all mentioned YAML files, which was generating a test report regardless of the previous steps' outcomes.
Updated the target framework version from .NET 8.0 to .NET 9.0 in multiple files: - In `BuildContext.cs`, changed `Framework` property of `DotNetRunSettings` from `"net8.0"` to `"net9.0"`. - In `AXSharp.templates.csproj`, updated `<TargetFramework>` element from `net8.0` to `net9.0`. - In `axsharpconsole.app.csproj`, updated `<TargetFramework>` element from `net8.0` to `net9.0`.
Updated `TestCollectionOrderer` attribute namespace in `DisplayNameOrderer.cs`. Removed various `Onliner` type properties and `Parent` and `Interpreter` properties across multiple classes and namespaces. Added methods `GetChildren`, `GetKids`, and `GetValueTags` to return collections of children, elements, and value tags. Updated `units.csproj` to target `net9.0` and updated package references.
Modified BuildContext to update ProcessRunner arguments and added new properties. Updated TestsTask to use >= for TestLevel and replaced AX_WEBAPI_TARGET with AXTARGET. Removed AXSharp-L3-tests.slnf. Added conditional compilation in ApaxTests. Updated TestConnector to use environment variables. Updated apax.yml with new targets, dependencies, and scripts. Enhanced Entry.cs with new methods and environment variables. Updated integrated.csproj to include new certificates. Removed conditional delays in PlainersSwappingTests and GH_ISSUE_183. Added new solution filters for integration and WebAPI tests. Added new certificate files.
…_be_rather_placed_into_onlinenamespace_Poco_instead_of_Poco_onlinenamespace [NEW-FEATURE] Poco types should be rather placed into onlinenamespace.Poco instead of Poco.onlinenamespace
…ostfixed pocos namespaces are backed prefixed instead of postfixed
updates vulnerable depencencies, removes some warnigs from CI/CD build
…about type when more than libraries are imported"
…ilation_object_loses_semantic_information_about_type_when_more_than_libraries_are_imported Revert "[POSSIBLE-BUG] Compilation object loses semantic information about type when more than libraries are imported"
Refactored methods in `SemanticsHelpers.cs` to return tuples for eligibility checks, providing more detailed information. Updated various files to use the new tuple return type for member eligibility checks. Modified `CsPlainConstructorBuilder.cs` and `CsPlainSourceBuilder.cs` to store eligibility check results in variables before conditional logic. Updated `launchSettings.json` to change the `workingDirectory` path for the `ixc-simple-template` project configuration.
Updated method signatures in `SemanticsHelpers` to use `eligibleType` instead of `qualifiedName` for clarity and consistency. Enhanced `FindTypeDeclaration` method with additional null and type checks. Refactored multiple builder classes to consistently use `eligibleType`. Added or modified comments for future refactoring or debugging. Updated `launchSettings.json` to include `--skip-deps` argument for `ixc-simple-template` project configuration.
…Helpers.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Corrected the property name 'isEligibe' to 'isEligible' across multiple files to ensure consistency and correctness. Changes include: - Updated return statement in `SemanticsHelpers.cs` to use `eligibility.isEligible`. - Updated condition checks in `CsOnlinerMemberBuilder.cs`, `CsOnlinerPlainerOnlineToPlainBuilder.cs`, `CsOnlinerPlainerPlainToOnlineBuilder.cs`, `CsOnlinerPlainerPlainToShadowBuilder.cs`, `CsOnlinerPlainerShadowToPlainBuilder.cs`, `CsOnlinerHasChangedBuilder.cs`, and `CsPlainSourceBuilder.cs` to use `eligibility.isEligible`.
Missing types in smodel
- Enhanced logging in `SemanticsHelpers` class to include filename and line position for type access issues.
Updated the catch block in the SemanticsHelpers class to log a warning message using Log.Logger.Warning when an exception is caught. This change enhances visibility into potential issues by providing a warning message that indicates the system failed to determine the location of the type declaration for the specified typeAccess?.TypeSymbol?.Name.
…xsharp into missing-types-in-smodel
Enhance logging and update launch settings
Updated AddPropertyDeclaration in CsPlainSourceBuilder to accept an additional parameter `eligibleType` of type `IDeclaration`. Modified the switch statement to process `eligibility.eligibleType` and updated method calls accordingly. This ensures accurate type information is used during source code generation, enhancing the flexibility and precision of the transpilation process.
…iner-fields-when-eligible [BUG]ixc does not transpile plainer fields when eligible
added top row with combobox for localization
Update stc to v9
Introduce a new raw property `${AccessQualifier} ${Type} ${Identifier}_raw`
in the `AddedPropertyDeclarationAstNode` class to provide direct access
to the underlying field. Update existing property logic to include this
new raw property. The getter for the raw property returns the underlying
field `_Identifier`.
…-without-interpolation-and-tranlsation
Added a closing brace to the getter method of Identifier_raw in AddedPropertyDeclarationAstNode.cs. Also added a newline character before the new getter method definition.
…ibute-string-without-interpolation-and-tranlsation [FEATURE] Add raw value of attribute (string) without interpolation and tranlsation
…rrealshadowcontrolview
…et-by-onlinerrealshadowcontrolview 398 bug the shadow value is not set by onlinerrealshadowcontrolview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release aims to preserve state of the project before we move to substantial changes while moving from bootstrap to tailwind.
This pull request includes several updates to GitHub workflows, issue templates, and project configuration files, along with some cleanup and policy changes. The most significant changes involve the removal of unused workflows, updates to support .NET 9.0, and modifications to project documentation and ownership.
Workflow and Automation Updates:
.github/actions/apax-buildand.github/actions/setup-apax-runneractions, along with the.github/workflows/create_issue.yml,.github/workflows/static.yml, and.github/issue-branch.ymlworkflows, as they are no longer in use. [1] [2] [3] [4] [5].github/workflows/dev.yml,.github/workflows/master.yml,.github/workflows/pr-dev.yml, and.github/workflows/release.ymlto add support for .NET 9.0 and include theAXrunner label. [1] [2] [3] [4] [5] [6] [7]Project Configuration Changes:
Directory.Build.propsto includenet9.0as a target framework, enabling compatibility with the latest .NET version.Documentation and Policy Updates:
CODE_OF_CONDUCT.mdfile, replacing the detailed Contributor Covenant with a brief set of straightforward guidelines.CONTRIBUTING.mdto reflect the new repository URL (inxton/axsharp) for discussions and issues.CODEOWNERSto reflect changes in team ownership.Issue Template Updates:
.github/ISSUE_TEMPLATE/bug_report.mdand.github/ISSUE_TEMPLATE/question.mdfromix-axtoinxton. [1] [2]