Skip to content

[IP-841]: Copy Quote UI feedback #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naui95 merged 7 commits into from
Sep 29, 2024
Merged

[IP-841]: Copy Quote UI feedback #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22ad2d6
Bugfix: Other client can be selected from list
Verony-makesIT Feb 21, 2023
9cefc8a
Bugfix: Selected quote date is saved
Verony-makesIT Feb 21, 2023
203909b
Fix #841 Copy quote (modal) UI feedback
Verony-makesIT Feb 21, 2023
87bc07b
Adapt copy custom fields code if null
Verony-makesIT Mar 11, 2024
c279fd9
Revert some accidently changes
Verony-makesIT Mar 30, 2024
b681d40
implemented alternative solution
naui95 Sep 29, 2024
f3f22d7
formatting improvement
naui95 Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions application/modules/invoices/views/modal_copy_invoice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
$('#copy_invoice_confirm').click(function () {
$.post("<?php echo site_url('invoices/ajax/copy_invoice'); ?>", {
invoice_id: <?php echo $invoice_id; ?>,
client_id: $('#client_id').val(),
client_id: $('#copy_invoice_client_id').val(),
invoice_date_created: $('#invoice_date_created_modal').val(),
invoice_group_id: $('#invoice_group_id').val(),
invoice_password: $('#invoice_password').val(),
Expand All @@ -21,7 +21,7 @@
payment_method: $('#payment_method').val()
},
function (data) {
<?php echo(IP_DEBUG ? 'console.log(data);' : ''); ?>
<?php echo IP_DEBUG ? 'console.log(data);' : ''; ?>
var response = JSON.parse(data);
if (response.success === 1) {
window.location = "<?php echo site_url('invoices/view'); ?>/" + response.invoice_id;
Expand Down Expand Up @@ -54,11 +54,11 @@ function (data) {
value="<?php echo $invoice->payment_method; ?>">

<div class="form-group">
<label for="client_id"><?php _trans('client'); ?></label>
<select name="client_id" id="client_id" class="form-control" autofocus="autofocus">
<option value="<?php echo $invoice->client_id; ?>">
<?php echo format_client($invoice); ?>
</option>
<label for="copy_invoice_client_id"><?php _trans('client'); ?></label>
<select name="client_id" id="copy_invoice_client_id" class="client-id-select form-control" autofocus="autofocus">
<?php if ( ! empty($client)) : ?>
<option value="<?php echo $client->client_id; ?>"><?php _htmlsc(format_client($client)); ?></option>
<?php endif; ?>
</select>
</div>

Expand Down
Loading