[Develop 1.7]: CodeIgniter3 for php-8.2+ and maintained by pocketarc#1237
Closed
nielsdrost7 wants to merge 14 commits intodevelopmentfrom
Closed
[Develop 1.7]: CodeIgniter3 for php-8.2+ and maintained by pocketarc#1237nielsdrost7 wants to merge 14 commits intodevelopmentfrom
nielsdrost7 wants to merge 14 commits intodevelopmentfrom
Conversation
Minor Changes to work with php 5.4 to 8.4 from codeigniter/framework : 3.1.13 (automaintened) to https://github.com/pocketarc/codeigniter : 3.3.0 Need run `composer update` or `composer install` thx CI say : Your system folder path does not appear to be set correctly. Please open the following file and correct this: `index.php` From: codeigniter/framework 3.1.13 (official unmaintened) `$system_path = 'vendor/codeigniter/framework/system';` To: pocketarc/codeigniter #3.3.0 (CI3 maintened fork php-8.4) `$system_path = 'vendor/pocketarc/codeigniter/system';` Filename: MX/Controller.php (add $load class var) + Old Fix: Creation of dynamic property Setup::$load is deprecated + typo indent Line Numbers: 54,55 From run($module = '', $group = '') #origin CI-3.1.13 To run($config = null, &$data = null) + #Fix [3.3.0](https://github.com/pocketarc/codeigniter) Severity: Compile Error Message: Declaration of MY_Form_validation::run($module = '', $group = '') must be compatible with CI_Form_validation::run($config = null, &$data = null) Filename: libraries/MY_Form_validation.php Line Number: 34
See: https://www.php.net/releases/8.4/#deprecations_and_bc_breaks and pocketarc/codeigniter@8311086 Note: minimum PHP5.3 with this change.
7 tasks
This was referenced Apr 28, 2025
Like other models Fix on save: Form_validation: set_rules() called with an empty $rules parameter See: #1195
* Chore: improve docs (#1230) * Change README.md * Update README.md * Change CONTRIBUTING.md * Improve TRANSLATIONS.md * Improve TRANSLATIONS.md * Create INSTALLATION.md * Update CONTRIBUTING.md * Improve CONTRIBUTING.md * Update CONTRIBUTING.md * Improve README.md (community & support) * Improve CONTRIBUTING.md * Improve INSTALLATION.md * Update README.md * Create bug_report.yml * Create feature_request.yml * Create translations.yml * Update bug_report.yml * Update feature_request.yml * Update translations.yml * Update PULL_REQUEST_TEMPLATE.md * Improve PULL_REQUEST_TEMPLATE.md * Update test-frontend.yml * Update test-php.yml * Improve test-php.yml * docker php-fpm test and build * Create docker-nginx.yml * Create docker-mariadb.yml * Create docker-phpmyadmin.yml * Improvements INSTALLATION.md * Create TRANSLATIONS.md (#1262)
Form_validation: set_rules() called with an empty $rules parameter See: #1195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attention
This is @sudwebdesign 's PR, I just had to merge it, to get another PR into this one
Originally #1161
Description
Minor Changes to work with php 5.4 to 8.4
from auto-maintained codeigniter/framework : 3.1.13
to maintained pocketarc/codeigniter : 3.3.0
Need run
composer updateorcomposer installcloses #1223 #1180 #1009
Changelog
Thx CI say :
Your system folder path does not appear to be set correctly.
Please open the following file and correct this:
index.phpFrom: codeigniter/framework v3.1.13 (official unmaintened)
$system_path = 'vendor/codeigniter/framework/system';To: pocketarc/codeigniter v3.3.0 (CI3 maintened fork)
$system_path = 'vendor/pocketarc/codeigniter/system';Filename: MX/Controller.php (add $load class var)
From run($module = '', $group = '') #origin CI-3.1.13 To run($config = null, &$data = null)
Severity: Compile Error Message:
Declaration of MY_Form_validation::run($module = '', $group = '')must be compatible with
CI_Form_validation::run($config = null, &$data = null)Filename: libraries/MY_Form_validation.php Line Number: 34
Related Issue
Maybe https://github.com/orgs/InvoicePlane/discussions/1067
Motivation and Context
Simplify maintenance (Only App with this)
Pull Request Checklist
Issue Type