Fix #fullpage-loader (Spinner) never showed after save by sudwebdesign · Pull Request #1179 · InvoicePlane/InvoicePlane

sudwebdesign · 2025-01-03T15:23:05Z

Description

$(document).on('click', '.ajax-loader', function () { duplicated inside same function.

Pull Request Checklist

My code follows the code formatting guidelines.
I have an issue ID for this pull request.
I selected the corresponding branch.
I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

Bugfix
Improvement of an existing Feature
New Feature

`$(document).on('click', '.ajax-loader', function () {` Is duplicated inside same function.

sudwebdesign · 2025-01-03T15:26:40Z

Hi @nielsdrost7 On Click save for invoice, quote, ...

not show #fullpage-loader

nielsdrost7 · 2025-01-03T15:57:07Z

@sudwebdesign I think we had that because of this problem: #1130

Apply your fix
Leave forms like the product form or payment form completely empty and save

The full page loader will show, but it will time out and it will not show the validation errors.

If you can resolve that problem, I'll be very grateful.

(The bug was introduced between 1.6.1 and 1.6.2)

sudwebdesign · 2025-01-03T20:06:28Z

The full page loader will show, but it will time out and it will not show the validation errors.

Sorry but this is solved by if (!requiredFieldsFilledIn) return;

// Checks if required fields are filled it. If not, don't display spinner.

See in PR #1155

But the 2nd event (in event) never called and do not show spinner #fullpage-loader.

See Add Product in action with this Fix:

Click on Save button and (browser) scroll to empty required Product Name field. After filled product name, i push the Enter and auto scroll to empty required Price field. After set and push Enter or Click Save button IP show #fullpage-loader (spinner) normally :)

sudwebdesign · 2025-01-03T20:20:21Z

@nielsdrost7 ~~(maybe after apply this fix)~~ Need to reload browser cache with Ctrl + F5

sudwebdesign · 2025-01-04T11:46:30Z

Hi @nielsdrost7

Before the fix, need to click twice on Save button to show the spinner (double send request on server is possible)

I think we had that because of this problem: #1130

Maybe it's an oversight when editing the code, it doesn't make sense to have a click event within a click event. I missed the double event in PR #1155, mea culpa.

The problem with required fields #1130 already been corrected by #1155

sudwebdesign · 2025-01-04T12:02:35Z

It's work with new client, product, ... (when element have ajax-loader in attribute class)

nielsdrost7 · 2025-01-04T12:22:59Z

@sudwebdesign merci!
I'll take a look when I have some time

Now, when form marked invalid by the browser The spinner don't appear (not only with req. fields empty) To test: Send quote/invoice email with client and/or user email like `my_mail` Before this patch IP show the spinner (Like issue #1130) Note: Improve PR #1155 & #1179 Tested with Chromium, Firefox and is widely available now (2025) See: https://stackoverflow.com/questions/5846382/a-way-to-check-validity-of-html5-forms#63606174 https://developer.mozilla.org/docs/Web/API/HTMLInputElement/checkValidity https://developer.mozilla.org/docs/Web/API/ValidityState

@sudwebdesign

## Version 1.6.3 (final) ### Major Features & E-Invoicing * [[IP-1268](#1268)] **E-invoicing infrastructure update** by @sudwebdesign * [[IP-1272](#1272)] **E-invoicing enhancements** by @sudwebdesign * [[IP-1247](#1247)] Processing e-invoices flow (and some bugfixes) for version 1.6.3 by @nielsdrost7 * [[IP-1282](#1282)] feat: Legacy calculation setup step by @pumpi * [[IP-1281](#1281)] fix: Client overview shows wrong e-Invoicing state by @pumpi ### Changed / Improvements * [[IP-1277](#1277)] Replace node-sass with sass by @onny * [[IP-1261](#1261)] Guest Payment stripe flow & online_payment lang improved by @nielsdrost7 * [[IP-1178](#1178)] Add custom_fields in controllers/Settings by @sudwebdesign * [[IP-1206](#1206)] Add report: Invoices per client by @mheiduk * [[IP-1228](#1228)] Improve number_helper & standardize_amount (fix european format) by @sudwebdesign * [[IP-1229](#1229)] Remove unattended standardize_amount in payments view form by @sudwebdesign * [[IP-1241](#1241)] Add pagination to invoice and quote templates by @onny * [[IP-1219](#1219)] Sort invoices by date instead of id by @MrKrisKrisu * [[IP-1222](#1222)] Sort quotes by date instead of id by @sudwebdesign ### Fixed * [[IP-1179](#1179)] Fix #fullpage-loader (Spinner) never showed after save by @sudwebdesign * [[IP-1174](#1174)] Removed '.pdf' from Invoices.php downloads to fix issue by @HeapReaper * [[IP-1175](#1175)] Check invoice balance before rendering QR code in web view by @idressos * [[IP-1183](#1183)] Fix summary client delete button go to 404 (link2form) by @sudwebdesign * [[IP-1185](#1185)] Fix styling in clients table header by @tstoeter * [[IP-1186](#1186)] Style2class for amounts & balances (th & tr) by @sudwebdesign * [[IP-1197](#1197)] Send email show blank page (php>=8.2) by @sudwebdesign * [[IP-1199](#1199)] Add invoice_status case in template_helper by @sudwebdesign * [[IP-1201](#1201)] Fix SMTP password wrong after saving settings by @sudwebdesign * [[IP-1204](#1204)] Update template_helper.php to fix email template with custom single choice field by @LOK-Soft * [[IP-1251](#1251)] fix: amount of the credit transfer cannot be smaller than 0.01 Euro by @mheiduk * [[IP-1278](#1278)] Fix: Styling issues by @pumpi * [[IP-1283](#1283)] fix: Client detail view exception by **Full Changelog**: v1.6.2...v1.6.3

@sudwebdesign

### What's Changed (since v1.6.2) #### Major Features & E-Invoicing * [[IP-1268](#1268)] **E-invoicing infrastructure update** by @sudwebdesign * [[IP-1272](#1272)] **E-invoicing enhancements** by @sudwebdesign * [[IP-1247](#1247)] Processing e-invoices flow (and some bugfixes) for version 1.6.3 by @nielsdrost7 * [[IP-1282](#1282)] feat: Legacy calculation setup step by @pumpi * [[IP-1281](#1281)] fix: Client overview shows wrong e-Invoicing state by @pumpi #### Changed / Improvements * [[IP-1277](#1277)] Replace node-sass with sass by @onny * [[IP-1261](#1261)] Guest Payment stripe flow & online_payment lang improved by @nielsdrost7 * [[IP-1178](#1178)] Add custom_fields in controllers/Settings by @sudwebdesign * [[IP-1206](#1206)] Add report: Invoices per client by @mheiduk * [[IP-1228](#1228)] Improve number_helper & standardize_amount (fix european format) by @sudwebdesign * [[IP-1229](#1229)] Remove unattended standardize_amount in payments view form by @sudwebdesign * [[IP-1241](#1241)] Add pagination to invoice and quote templates by @onny * [[IP-1219](#1219)] Sort invoices by date instead of id by @MrKrisKrisu * [[IP-1222](#1222)] Sort quotes by date instead of id by @sudwebdesign #### Fixed * [[IP-1179](#1179)] Fix #fullpage-loader (Spinner) never showed after save by @sudwebdesign * [[IP-1174](#1174)] Removed '.pdf' from Invoices.php downloads to fix issue by @HeapReaper * [[IP-1175](#1175)] Check invoice balance before rendering QR code in web view by @idressos * [[IP-1183](#1183)] Fix summary client delete button go to 404 (link2form) by @sudwebdesign * [[IP-1185](#1185)] Fix styling in clients table header by @tstoeter * [[IP-1186](#1186)] Style2class for amounts & balances (th & tr) by @sudwebdesign * [[IP-1197](#1197)] Send email show blank page (php>=8.2) by @sudwebdesign * [[IP-1199](#1199)] Add invoice_status case in template_helper by @sudwebdesign * [[IP-1201](#1201)] Fix SMTP password wrong after saving settings by @sudwebdesign * [[IP-1204](#1204)] Update template_helper.php to fix email template with custom single choice field by @LOK-Soft * [[IP-1251](#1251)] fix: amount of the credit transfer cannot be smaller than 0.01 Euro by @mheiduk * [[IP-1278](#1278)] Fix: Styling issues by @pumpi * [[IP-1283](#1283)] fix: Client detail view exception by **Full Changelog**: v1.6.2...v1.6.3

@sudwebdesign

* [[IP-1268](InvoicePlane#1268)] **E-invoicing infrastructure update** by @sudwebdesign * [[IP-1272](InvoicePlane#1272)] **E-invoicing enhancements** by @sudwebdesign * [[IP-1247](InvoicePlane#1247)] Processing e-invoices flow (and some bugfixes) for version 1.6.3 by @nielsdrost7 * [[IP-1282](InvoicePlane#1282)] feat: Legacy calculation setup step by @pumpi * [[IP-1281](InvoicePlane#1281)] fix: Client overview shows wrong e-Invoicing state by @pumpi * [[IP-1277](InvoicePlane#1277)] Replace node-sass with sass by @onny * [[IP-1261](InvoicePlane#1261)] Guest Payment stripe flow & online_payment lang improved by @nielsdrost7 * [[IP-1178](InvoicePlane#1178)] Add custom_fields in controllers/Settings by @sudwebdesign * [[IP-1206](InvoicePlane#1206)] Add report: Invoices per client by @mheiduk * [[IP-1228](InvoicePlane#1228)] Improve number_helper & standardize_amount (fix european format) by @sudwebdesign * [[IP-1229](InvoicePlane#1229)] Remove unattended standardize_amount in payments view form by @sudwebdesign * [[IP-1241](InvoicePlane#1241)] Add pagination to invoice and quote templates by @onny * [[IP-1219](InvoicePlane#1219)] Sort invoices by date instead of id by @MrKrisKrisu * [[IP-1222](InvoicePlane#1222)] Sort quotes by date instead of id by @sudwebdesign * [[IP-1179](InvoicePlane#1179)] Fix #fullpage-loader (Spinner) never showed after save by @sudwebdesign * [[IP-1174](InvoicePlane#1174)] Removed '.pdf' from Invoices.php downloads to fix issue by @HeapReaper * [[IP-1175](InvoicePlane#1175)] Check invoice balance before rendering QR code in web view by @idressos * [[IP-1183](InvoicePlane#1183)] Fix summary client delete button go to 404 (link2form) by @sudwebdesign * [[IP-1185](InvoicePlane#1185)] Fix styling in clients table header by @tstoeter * [[IP-1186](InvoicePlane#1186)] Style2class for amounts & balances (th & tr) by @sudwebdesign * [[IP-1197](InvoicePlane#1197)] Send email show blank page (php>=8.2) by @sudwebdesign * [[IP-1199](InvoicePlane#1199)] Add invoice_status case in template_helper by @sudwebdesign * [[IP-1201](InvoicePlane#1201)] Fix SMTP password wrong after saving settings by @sudwebdesign * [[IP-1204](InvoicePlane#1204)] Update template_helper.php to fix email template with custom single choice field by @LOK-Soft * [[IP-1251](InvoicePlane#1251)] fix: amount of the credit transfer cannot be smaller than 0.01 Euro by @mheiduk * [[IP-1278](InvoicePlane#1278)] Fix: Styling issues by @pumpi * [[IP-1283](InvoicePlane#1283)] fix: Client detail view exception by **Full Changelog**: InvoicePlane/InvoicePlane@v1.6.2...v1.6.3

@sudwebdesign

### What's Changed (since v1.6.2) #### Major Features & E-Invoicing * [[IP-1268](InvoicePlane#1268)] **E-invoicing infrastructure update** by @sudwebdesign * [[IP-1272](InvoicePlane#1272)] **E-invoicing enhancements** by @sudwebdesign * [[IP-1247](InvoicePlane#1247)] Processing e-invoices flow (and some bugfixes) for version 1.6.3 by @nielsdrost7 * [[IP-1282](InvoicePlane#1282)] feat: Legacy calculation setup step by @pumpi * [[IP-1281](InvoicePlane#1281)] fix: Client overview shows wrong e-Invoicing state by @pumpi #### Changed / Improvements * [[IP-1277](InvoicePlane#1277)] Replace node-sass with sass by @onny * [[IP-1261](InvoicePlane#1261)] Guest Payment stripe flow & online_payment lang improved by @nielsdrost7 * [[IP-1178](InvoicePlane#1178)] Add custom_fields in controllers/Settings by @sudwebdesign * [[IP-1206](InvoicePlane#1206)] Add report: Invoices per client by @mheiduk * [[IP-1228](InvoicePlane#1228)] Improve number_helper & standardize_amount (fix european format) by @sudwebdesign * [[IP-1229](InvoicePlane#1229)] Remove unattended standardize_amount in payments view form by @sudwebdesign * [[IP-1241](InvoicePlane#1241)] Add pagination to invoice and quote templates by @onny * [[IP-1219](InvoicePlane#1219)] Sort invoices by date instead of id by @MrKrisKrisu * [[IP-1222](InvoicePlane#1222)] Sort quotes by date instead of id by @sudwebdesign #### Fixed * [[IP-1179](InvoicePlane#1179)] Fix #fullpage-loader (Spinner) never showed after save by @sudwebdesign * [[IP-1174](InvoicePlane#1174)] Removed '.pdf' from Invoices.php downloads to fix issue by @HeapReaper * [[IP-1175](InvoicePlane#1175)] Check invoice balance before rendering QR code in web view by @idressos * [[IP-1183](InvoicePlane#1183)] Fix summary client delete button go to 404 (link2form) by @sudwebdesign * [[IP-1185](InvoicePlane#1185)] Fix styling in clients table header by @tstoeter * [[IP-1186](InvoicePlane#1186)] Style2class for amounts & balances (th & tr) by @sudwebdesign * [[IP-1197](InvoicePlane#1197)] Send email show blank page (php>=8.2) by @sudwebdesign * [[IP-1199](InvoicePlane#1199)] Add invoice_status case in template_helper by @sudwebdesign * [[IP-1201](InvoicePlane#1201)] Fix SMTP password wrong after saving settings by @sudwebdesign * [[IP-1204](InvoicePlane#1204)] Update template_helper.php to fix email template with custom single choice field by @LOK-Soft * [[IP-1251](InvoicePlane#1251)] fix: amount of the credit transfer cannot be smaller than 0.01 Euro by @mheiduk * [[IP-1278](InvoicePlane#1278)] Fix: Styling issues by @pumpi * [[IP-1283](InvoicePlane#1283)] fix: Client detail view exception by **Full Changelog**: InvoicePlane/InvoicePlane@v1.6.2...v1.6.3

Fix fullpage-loader helper never showed

e609054

`$(document).on('click', '.ajax-loader', function () {` Is duplicated inside same function.

sudwebdesign changed the title ~~Fix fullpage-loader helper never showed~~ Fix #fullpage-loader DIV helper never showed Jan 3, 2025

sudwebdesign changed the title ~~Fix #fullpage-loader DIV helper never showed~~ Fix #fullpage-loader (Spinner) never showed after save Jan 3, 2025

Remove event unused JS var (Fullpage loader)

c5765cb

naui95 added this to the 1.6.3 (bugfix) milestone Jan 11, 2025

nielsdrost7 merged commit 7d4af21 into InvoicePlane:development Jan 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #fullpage-loader (Spinner) never showed after save#1179

Fix #fullpage-loader (Spinner) never showed after save#1179
nielsdrost7 merged 2 commits intoInvoicePlane:developmentfrom
sudwebdesign:fix-v162-fullpage-loader-never-show

sudwebdesign commented Jan 3, 2025

Uh oh!

sudwebdesign commented Jan 3, 2025 •

edited

Loading

Uh oh!

nielsdrost7 commented Jan 3, 2025

Uh oh!

sudwebdesign commented Jan 3, 2025 •

edited

Loading

Uh oh!

sudwebdesign commented Jan 3, 2025 •

edited

Loading

Uh oh!

sudwebdesign commented Jan 4, 2025

Uh oh!

sudwebdesign commented Jan 4, 2025

Uh oh!

nielsdrost7 commented Jan 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sudwebdesign commented Jan 3, 2025

Description

Pull Request Checklist

Issue Type (Please check one or more)

Uh oh!

sudwebdesign commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nielsdrost7 commented Jan 3, 2025

Uh oh!

sudwebdesign commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sudwebdesign commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sudwebdesign commented Jan 4, 2025

Uh oh!

sudwebdesign commented Jan 4, 2025

Uh oh!

nielsdrost7 commented Jan 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sudwebdesign commented Jan 3, 2025 •

edited

Loading

sudwebdesign commented Jan 3, 2025 •

edited

Loading

sudwebdesign commented Jan 3, 2025 •

edited

Loading