Skip to content

Update cardano-cli to the new limit for stake pool metadata url #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnalotoski merged 1 commit into from
Sep 22, 2025
Merged

Update cardano-cli to the new limit for stake pool metadata url #1284

johnalotoski merged 1 commit into from
Sep 22, 2025

Conversation

@CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Sep 18, 2025

Changelog

- description: |
    Update cardano-cli to the new limit for stake pool metadata url on pair with https://github.com/IntersectMBO/cardano-ledger/issues/3941
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

More than a year ago this change occurred in ledger IntersectMBO/cardano-ledger#3941, we implemented for Conway URLs but failed to do so for stake pool metadata.

It has been decided to increase the length limit for Url type from 64 bytes to 128 bytes. We can't really go much higher than 128 bytes because that would be very disruptive for hardware wallet engineers.

This limit should be increased at the deserialization level starting with protocol version 9

A new QuickCheck generator also needs to be implemented for the roundtrip tests and CDDL needs to be adjusted for Conway for Anchors and StakePool params.

How to trust this PR

With 129 bytes url

cardano-cli conway stake-pool registration-certificate \
--cold-verification-key-file cold.vkey --vrf-verification-key-file vrf.vkey --pool-pledge 9000000000 --pool-cost 340000000 --pool-margin 05/100 --pool-reward-account-verification-key-file stake.vkey --pool-owner-stake-verification-key-file stake.vkey --testnet-magic 2 --pool-relay-ipv4 10.1.1.1 --pool-relay-port 5000 \
--metadata-url "https://raw.githubusercontent.com/carloslodelar/proposals/refs/heads/main/sample-metadata-creating-a-129-bytes-url-111111111.json" \
--metadata-hash "2412f77be9b650eff7b015455d15cea355e1782dda2e7d7b1cb34943eefac348" \
--out-file pool-registration.cert

option --metadata-url: The provided string must have at most 128 characters, but it has 129 characters.

with 128 bytes url

cardano-cli conway stake-pool registration-certificate \
--cold-verification-key-file cold.vkey \
--vrf-verification-key-file vrf.vkey \
--pool-pledge 9000000000 \
--pool-cost 340000000 \
--pool-margin 05/100 \
--pool-reward-account-verification-key-file stake.vkey \
--pool-owner-stake-verification-key-file stake.vkey \
--testnet-magic 2 \
--pool-relay-ipv4 10.1.1.1 \
--pool-relay-port 5000 \
--metadata-url "https://raw.githubusercontent.com/carloslodelar/proposals/refs/heads/main/sample-metadata-creating-a-128-bytes-url-11111111.json" \
--metadata-hash "e061d2e7d5900eb775554b918e85a1e12e34f864a62c611f96e09477ec472944" \
--out-file pool-registration.cert

cardano-cli conway transaction build \
--tx-in bdc0acc28c9feb05cacfd8e36a0f2502e671af0a7908b8301201f3a18d553f11#0 \
--change-address addr_test1vqtt24w6gzsknx2h0rdsje80auc0wthdng4jlwuxpm5wrlgsezmwf \
--certificate-file ~/test128byteurl/pool-registration.cert \
--out-file tx.raw
Estimated transaction fee: 934 Lovelace

cardano-cli conway transaction sign \
--tx-file tx.raw --signing-key-file utxo.skey \
--signing-key-file ~/test128byteurl/cold.skey \
--signing-key-file ~/test128byteurl/stake.skey \
--out-file tx.signed

cardano-cli conway transaction submit \
--tx-file tx.signed 
Transaction successfully submitted. Transaction hash is:
{"txhash":"5acae395104d6acb68fdad10237f380267547eeae74564e0bf5911b33fc93c71"}

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 22, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Sep 22, 2025
Merged via the queue into master with commit 07a2859 Sep 22, 2025
26 checks passed
@johnalotoski johnalotoski deleted the clr/metadataurlsize branch September 22, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlosLopezDeLara @carbolymer @johnalotoski