Skip to content

Build cardano-cli non-system deps statically and relink system deps for darwin builds #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palas merged 1 commit into from
Sep 4, 2025
Merged

Build cardano-cli non-system deps statically and relink system deps for darwin builds #1269

palas merged 1 commit into from
Sep 4, 2025

Conversation

@palas
Copy link
Contributor

@palas palas commented Sep 2, 2025 •
edited
Loading

Changelog

- description: |
    Build `cardano-cli` non-system deps statically and relink system deps for `darwin` builds in releases
  type:
  - bugfix

Context

See issue #1211 for more information.

How to trust this PR

Check the fake test release: https://github.com/IntersectMBO/cardano-cli/releases/tag/untagged-243a40b50e8aa609dbef

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Sep 2, 2025
@palas palas requested a review from a team September 2, 2025 19:50
@palas palas requested a review from a team as a code owner September 2, 2025 19:50
@palas palas linked an issue Sep 2, 2025 that may be closed by this pull request
Pre-built binary packages on aarch64-darwin platform do not work as expected #1211
Closed
@palas palas force-pushed the pack-deps-for-darwin-binaries branch 2 times, most recently from e126668 to e70c74a Compare September 2, 2025 20:34
carbolymer
carbolymer reviewed Sep 3, 2025
View reviewed changes
carbolymer
carbolymer reviewed Sep 3, 2025
View reviewed changes
@carbolymer carbolymer requested a review from angerman September 3, 2025 10:49
@palas palas force-pushed the pack-deps-for-darwin-binaries branch 7 times, most recently from cbde1fa to 41c3024 Compare September 3, 2025 23:08
@palas palas force-pushed the pack-deps-for-darwin-binaries branch 2 times, most recently from 98ec11c to 9b992f8 Compare September 4, 2025 16:41
@palas palas requested a review from carbolymer September 4, 2025 16:44
@palas palas changed the title Pack deps for darwin binaries Build cardano-cli non-system deps statically and relink system deps for darwin builds Sep 4, 2025
@palas palas enabled auto-merge September 4, 2025 18:10
@palas palas added this pull request to the merge queue Sep 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2025
@palas palas added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit ee8254e Sep 4, 2025
28 checks passed
@palas palas deleted the pack-deps-for-darwin-binaries branch September 4, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@angerman angerman Awaiting requested review from angerman

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pre-built binary packages on aarch64-darwin platform do not work as expected

4 participants

@palas @carbolymer @angerman