Skip to content

Fix legacy genesis creation #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jimbo4350 merged 6 commits into from
Sep 9, 2025
Merged

Fix legacy genesis creation #1267

Jimbo4350 merged 6 commits into from
Sep 9, 2025

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 26, 2025 •
edited
Loading

Changelog

Resolves #1262

- description: |
    `cardano-cli legacy genesis create` recently removed the ability to specify the alonzo era and therefore the ability to    
     generate a V2 cost model with 175 (instead of 185) parameters. This PR restores that functionality.
  type:
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 26, 2025
View reviewed changes
@Jimbo4350 Jimbo4350 force-pushed the jordan/fix-legacy-genesis-creation branch 2 times, most recently from fba6339 to 3ecb78b Compare August 26, 2025 13:32
carbolymer
carbolymer reviewed Aug 27, 2025
View reviewed changes
carbolymer
carbolymer reviewed Aug 27, 2025
View reviewed changes
palas
palas approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of suggestions to simplify the code

@Jimbo4350 Jimbo4350 force-pushed the jordan/fix-legacy-genesis-creation branch from eec8011 to 32be55d Compare August 27, 2025 19:50
@Jimbo4350 Jimbo4350 force-pushed the jordan/fix-legacy-genesis-creation branch 2 times, most recently from ac27861 to 7a5b4c1 Compare September 9, 2025 13:15
@Jimbo4350 Jimbo4350 enabled auto-merge September 9, 2025 13:15
@Jimbo4350 Jimbo4350 force-pushed the jordan/fix-legacy-genesis-creation branch from 7a5b4c1 to 78d9e03 Compare September 9, 2025 13:21
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Sep 9, 2025
Merged via the queue into master with commit b5ecb30 Sep 9, 2025
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/fix-legacy-genesis-creation branch September 9, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@palas palas palas approved these changes

@mkoura mkoura mkoura approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cardano-cli legacy genesis create creates alonzo genesis with too many cost model values

5 participants

@Jimbo4350 @carbolymer @palas @mkoura