Skip to content

Run weeder #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jimbo4350 merged 2 commits into from
Jul 25, 2025
Merged

Run weeder #1252

Jimbo4350 merged 2 commits into from
Jul 25, 2025

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jul 24, 2025 •
edited by palas
Loading

Changelog

- description: |
    Run weeder and remove suggested dead code
  type:
   - breaking
   - refactoring

Context

This is the weeder command and it's accompanying toml file:

  • weeder --config weeder.toml 
roots = [ "^Main.main$" ]
type-class-roots = true

You also need to put:

program-options
  ghc-options: -fwrite-ide-info

in your cabal.project.local file.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/refactor-2025-07-23 branch from 4993ae3 to 9c9b360 Compare July 24, 2025 13:28
palas
palas approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just removed functions so, if it compiles, I don't see a problem 👍

carbolymer
carbolymer requested changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're exposing all cardano-cli modules, some of them are used in tracing code in cardano node. If you confirm that the cardano-node repo builds with your changes I'll approve.

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Jul 24, 2025

We're exposing all cardano-cli modules, some of them are used in tracing code in cardano node. If you confirm that the cardano-node repo builds with your changes I'll approve.

Good catch, I'll confirm.

@Jimbo4350 Jimbo4350 force-pushed the jordan/refactor-2025-07-23 branch from 31d46d7 to 781305c Compare July 25, 2025 12:50
@Jimbo4350 Jimbo4350 enabled auto-merge July 25, 2025 12:50
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into master with commit 2124f5a Jul 25, 2025
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/refactor-2025-07-23 branch July 25, 2025 19:23
@palas palas mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@palas palas palas approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jimbo4350 @carbolymer @palas