Skip to content

Remove unnecessary calls to moduleWorkspace #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
newhoggy merged 1 commit into from
Jul 4, 2025
Merged

Remove unnecessary calls to moduleWorkspace #1245

newhoggy merged 1 commit into from
Jul 4, 2025

Conversation

@newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jul 3, 2025

Changelog

- description: |
    Remove unnecessary calls to `moduleWorkspace`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

These tests don't use the workspace, so don't bother creating one.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review July 3, 2025 12:44
@newhoggy newhoggy enabled auto-merge July 3, 2025 13:36
@newhoggy newhoggy disabled auto-merge July 3, 2025 23:38
@newhoggy newhoggy force-pushed the newhoggy/remove-unnecessary-calls-to-moduleWorkspace branch from ac4f729 to 7929102 Compare July 3, 2025 23:39
@newhoggy newhoggy enabled auto-merge July 3, 2025 23:39
@newhoggy newhoggy added this pull request to the merge queue Jul 3, 2025
Merged via the queue into master with commit 886c58c Jul 4, 2025
25 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-unnecessary-calls-to-moduleWorkspace branch July 4, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@newhoggy @carbolymer @Jimbo4350