Isolate protocol parameters update compatible command logic #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dcd991 to
a0b1c26
Compare
a0b1c26 to
83a38c9
Compare
palas
reviewed
May 26, 2025
carbolymer
reviewed
May 27, 2025
|
|
||
| module Cardano.CLI.EraBased.Governance.Actions.Option | ||
| ( pGovernanceActionCmds | ||
| ( dpGovActionProtocolParametersUpdate |
Contributor
There was a problem hiding this comment.
What does dp prefix stand for?
Suggested change
| ( dpGovActionProtocolParametersUpdate | |
| ( pGovActionProtocolParametersUpdate |
Contributor
Author
There was a problem hiding this comment.
Don't know but I'll change in a follow up PR.
carbolymer
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist