Skip to content

Change default era value from Babbage to Conway #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palas merged 1 commit into from
May 20, 2025
Merged

Change default era value from Babbage to Conway #1193

palas merged 1 commit into from
May 20, 2025

Conversation

@nbacquey
Copy link
Contributor

@nbacquey nbacquey commented May 20, 2025

Changelog

- description: |
    Change default era value from `babbage` to `conway`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Since most Babbage commands have been decommissioned, it makes no sense for babbage to be the default era, when none is provided to the CLI. This PR changes the default to conway instead. Additionally, it fixes an upstream bug in cardano-testnet where the default era was passed back as an input to cardano-cli.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@palas palas added this pull request to the merge queue May 20, 2025
Merged via the queue into master with commit 8945668 May 20, 2025
25 checks passed
@palas palas deleted the nb/fix_default_era branch May 20, 2025 15:43
@nbacquey nbacquey mentioned this pull request May 27, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nbacquey @Jimbo4350 @palas