RIO propagation 2025-05-09
#1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88fea17 to
5fb32e1
Compare
5fb32e1 to
38ef900
Compare
38ef900 to
0230e6b
Compare
0230e6b to
f477119
Compare
d2956b7 to
08f0d8c
Compare
1d026b2 to
a904df9
Compare
carbolymer
requested changes
May 20, 2025
| fromEitherCli | ||
| :: forall e m a | ||
| . (HasCallStack, MonadIO m, Show e, Typeable e, Error e) | ||
| :: (HasCallStack, MonadIO m, Show e, Typeable e, Error e) |
Contributor
There was a problem hiding this comment.
Those foralls were here on purpose. Now the order of type variables is sub-optimal. The problem here is that the previous version was allowing to use TypeApplications to enforce the error type i.e.
fromEitherCli @(FileError ()) fooNow with your version you need to do:
fromEitherCli @_ @(FileError ()) foowhich is a tad inconvenient.
Suggested change
| :: (HasCallStack, MonadIO m, Show e, Typeable e, Error e) | |
| :: (HasCallStack, Show e, Typeable e, Error e, MonadIO m) |
This applies to all the functions with removed foralls.
Contributor
Author
There was a problem hiding this comment.
I actually didn't notice this. I will revert the changes.
carbolymer
reviewed
May 20, 2025
| -> m a | ||
| fromExceptTCli = withFrozenCallStack $ fromEitherIOCli . runExceptT | ||
|
|
||
| handleFileErrorCli |
Contributor
There was a problem hiding this comment.
Why do we need this function? You can use fromEitherIOCli @(FileError ()) instead. This seems to be a needless specialisation.
carbolymer
reviewed
May 20, 2025
|
|
||
| let regCert = makeStakeAddressRegistrationCertificate req | ||
|
|
||
| fromEitherIOCli @(FileError ()) $ |
Contributor
There was a problem hiding this comment.
What's wrong with type applications?
05d80e0 to
25bce52
Compare
carbolymer
approved these changes
May 22, 2025
25bce52 to
a166aeb
Compare
a166aeb to
96c3c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist