Skip to content

Add windows build as an artefact to releases #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palas merged 1 commit into from
May 14, 2025
Merged

Add windows build as an artefact to releases #1182

palas merged 1 commit into from
May 14, 2025

Conversation

@palas
Copy link
Contributor

@palas palas commented May 13, 2025 •
edited
Loading

Changelog

- description: |
    - Added build for windows as an artefact for releases
  type:
  - feature

Context

We currently have binaries in releases for Linux and Mac OS, but not for Windows. Compiling from Windows is especially tricky, so users would especially benefit from being able to download binaries directly. In order to address this, this PR adds the result of the build with mingw32 as an artefact in releases.

How to trust this PR

See test run result: https://github.com/IntersectMBO/cardano-cli/releases/tag/untagged-b53131e2f2a938e8212f

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this May 13, 2025
@palas palas requested a review from a team May 13, 2025 13:38
@palas palas requested a review from a team as a code owner May 13, 2025 13:38
@palas palas force-pushed the add-win-build-to-release branch from 9d216be to 70456e5 Compare May 13, 2025 13:52
@palas palas force-pushed the add-win-build-to-release branch 5 times, most recently from 9244c38 to a838b16 Compare May 13, 2025 16:46
carbolymer
carbolymer reviewed May 14, 2025
View reviewed changes
carbolymer
carbolymer reviewed May 14, 2025
View reviewed changes
@palas palas force-pushed the add-win-build-to-release branch from a838b16 to 9bc2afc Compare May 14, 2025 10:54
@palas palas enabled auto-merge May 14, 2025 10:58
@palas palas changed the title Add windows build as artifact to releases Add windows build as artefact to releases May 14, 2025
@palas palas changed the title Add windows build as artefact to releases Add windows build as an artefact to releases May 14, 2025
@palas palas added this pull request to the merge queue May 14, 2025
Merged via the queue into master with commit 78c3e12 May 14, 2025
29 checks passed
@palas palas deleted the add-win-build-to-release branch May 14, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@palas @carbolymer