Standard output format for query ledger-peer-snapshot command
#1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1d7502 to
18a9fba
Compare
18a9fba to
fb2871d
Compare
Jimbo4350
approved these changes
May 7, 2025
Contributor
|
Perhaps json pretty format should be the default when outputting to a file, and otherwise plain json to the terminal. |
carbolymer
reviewed
May 7, 2025
Contributor
carbolymer
left a comment
There was a problem hiding this comment.
Why do we need output-json-pretty?
What do you think about defaulting to pretty JSON everywhere? If the produced data is large, let's add CBOR output format as well, in case a faster and more efficient format is needed.
…napshot' command. Also support json-pretty and yaml output.
fb2871d to
3affc83
Compare
carbolymer
reviewed
May 8, 2025
| text <- cborToText bs | ||
| pure $ LB.fromStrict $ Text.encodeUtf8 text | ||
|
|
||
| cborToTextLazyByteString :: LB.ByteString -> ExceptT HelpersError IO LBS.ByteString |
Contributor
Author
There was a problem hiding this comment.
I must have backed out the change that used it.
carbolymer
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Follows ADR-012
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist