Use lazy ByteString for writing out result of utxo query #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly reduces the amount of memory needed for the whole UTxO case
dda40dc to
21322c7
Compare
newhoggy
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly reduces the amount of memory needed for the whole UTxO case
Changelog
Context
Running
cardano-cli query utxo --whole-utxo --output-cbortakes up a large amount of memory as the UTxO is fetched and then serialized to hex cbor.How to trust this PR
The previous code was encoding to a lazy BS, converting it to strict, converting it back to lazy, and then writing it out as lazy. This just removes the intermediate strict BS by using the lazy variant of
Base16.The benefit is seen when doing
cardano-cli query utxo --whole-utxo --output-cbor: the memory footprint is quite a bit less.Checklist