Skip to content

Fix stakePools query output format #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carbolymer merged 1 commit into from
Apr 17, 2025
Merged

Fix stakePools query output format #1139

carbolymer merged 1 commit into from
Apr 17, 2025

Conversation

@mkoura
Copy link
Contributor

@mkoura mkoura commented Apr 16, 2025 •
edited by carbolymer
Loading

Corrected the output format for writeText and writeJson in writeStakePools function. Previously, writeText incorrectly outputed JSON and writeJson outputed text.

Changelog

- description: |
    Corrected the flipped text & JSON output format for `query stake-pools` function.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #1138

How to trust this PR

I've built the fixed binary and tested it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@mkoura
Fix stakePools output format
5f0018b 
Corrected the output format for `writeText` and `writeJson` in
`writeStakePools` function. Previously, `writeText` incorrectly outputed
JSON and `writeJson` outputed text.
@mkoura mkoura changed the title Fix stakePools output format Fix stakePools query output format Apr 16, 2025
@mkoura mkoura mentioned this pull request Apr 16, 2025
Closed
@jasagredo jasagredo mentioned this pull request Apr 16, 2025
Closed
@carbolymer carbolymer added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit ad4884c Apr 17, 2025
25 of 27 checks passed
@carbolymer carbolymer deleted the mkoura/flip_json_text_out branch April 17, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query stake-pools --output-json outputs text

3 participants

@mkoura @carbolymer