Skip to content

UTXO-HD for node 10.4 #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carbolymer merged 1 commit into from
Apr 18, 2025
Merged

UTXO-HD for node 10.4 #1134

carbolymer merged 1 commit into from
Apr 18, 2025

Conversation

@jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Apr 10, 2025 •
edited
Loading

Changelog

- description: |
    Implement changes needed for UTxO-HD Consensus feature.
    - Minor adjust on number of parameters of `AnyNewEpochState`.
    
    Update to latest `cardano-api 10.14.0.0`.
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@jasagredo jasagredo requested a review from a team April 10, 2025 08:21
@jasagredo jasagredo mentioned this pull request Apr 10, 2025
Closed
9 tasks
@jasagredo jasagredo force-pushed the utxo-hd-10.4 branch 3 times, most recently from da47e9a to 87dd79b Compare April 16, 2025 09:14
@jasagredo jasagredo mentioned this pull request Apr 16, 2025
Closed
@jasagredo jasagredo force-pushed the utxo-hd-10.4 branch 4 times, most recently from 027f9fc to 5d18d39 Compare April 17, 2025 09:10
@jasagredo
Copy link
Contributor Author

jasagredo commented Apr 17, 2025

Build failures on Windows are expected due to long paths in cardano-api. It will go away once we don't use SRPs.

@jasagredo
Copy link
Contributor Author

jasagredo commented Apr 17, 2025

Note that the PR description mentions:

Update to latest `cardano-api 10.14.0.0`.

This is not done yet but will be done before this PR is embarked in the queue.

Jimbo4350
Jimbo4350 reviewed Apr 17, 2025
View reviewed changes
cardano-cli/src/Cardano/CLI/EraIndependent/Debug/LogEpochState/Run.hs
(EpochNo maxBound)
()
( \(AnyNewEpochState sbe nes) _ _ -> do
( \(AnyNewEpochState sbe nes _) _ _ -> do
Copy link
Contributor

@Jimbo4350 Jimbo4350 Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to encode the tables here as well. cc: @carbolymer

Copy link
Contributor

@Jimbo4350 Jimbo4350 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss on slack. I wouldn't block the PR on this.

Jimbo4350
Jimbo4350 approved these changes Apr 17, 2025
View reviewed changes
cardano-cli/src/Cardano/CLI/EraIndependent/Debug/LogEpochState/Run.hs
(EpochNo maxBound)
()
( \(AnyNewEpochState sbe nes) _ _ -> do
( \(AnyNewEpochState sbe nes _) _ _ -> do
Copy link
Contributor

@Jimbo4350 Jimbo4350 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss on slack. I wouldn't block the PR on this.

@carbolymer carbolymer force-pushed the utxo-hd-10.4 branch 2 times, most recently from ace1246 to a832699 Compare April 18, 2025 07:14
@carbolymer carbolymer enabled auto-merge April 18, 2025 07:19
@carbolymer carbolymer disabled auto-merge April 18, 2025 08:32
@carbolymer carbolymer merged commit 0126543 into master Apr 18, 2025
24 of 25 checks passed
@carbolymer carbolymer deleted the utxo-hd-10.4 branch April 18, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasagredo @carbolymer @Jimbo4350