Skip to content

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Apr 7, 2025

Resolves: #1126

Changelog

- description: |
    Bump cardano-api to include bug fixes for:
    -  Silently dropping simple scripts in transaction construction
    -  Not selecting the highest protocol version in a given era. This resulted in erroneous plutus script decoding failures.
  type:
   - compatible   
   - bugfix        

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-cardano-api-version-20250407 branch 2 times, most recently from 1fd7148 to a611735 Compare April 7, 2025 21:17
@carbolymer
Copy link
Contributor

The changelog entry is too vague

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-cardano-api-version-20250407 branch 3 times, most recently from ae1e633 to 88008da Compare April 8, 2025 13:26
@Jimbo4350 Jimbo4350 changed the title Bump cardano-api to include bug fix for 1126 Bump cardano-api to include bug fixes for plutus script decoding and transaction construction Apr 8, 2025
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple version bump and golden file regeneration, all good 👍

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-cardano-api-version-20250407 branch from 88008da to 548cdc6 Compare April 8, 2025 13:51
@Jimbo4350 Jimbo4350 enabled auto-merge April 8, 2025 13:51
 Erroneous plutus script decoding failures
 Silently dropping simple scripts during transaction construction
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-cardano-api-version-20250407 branch from 548cdc6 to 3c8c473 Compare April 8, 2025 13:57
@Jimbo4350 Jimbo4350 requested a review from a team April 8, 2025 13:57
@Jimbo4350 Jimbo4350 requested a review from a team as a code owner April 8, 2025 13:57
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Apr 8, 2025
Merged via the queue into master with commit 4a33c3a Apr 8, 2025
24 of 25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/bump-cardano-api-version-20250407 branch April 8, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

script stripped from Tx

4 participants