Allow Plutus cost calculation to take offline data instead of querying the node #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
f98a9d8 to
885e91f
Compare
Jimbo4350
requested changes
Mar 10, 2025
838a241 to
685d8c8
Compare
690efe9 to
8a480f8
Compare
Jimbo4350
reviewed
Apr 11, 2025
Contributor
Jimbo4350
left a comment
There was a problem hiding this comment.
Nice work. After this round of commits and tidying up the commit history this is good to go.
carbolymer
previously requested changes
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
newhoggy
reviewed
Apr 14, 2025
19942ba to
ad7b1a8
Compare
ad7b1a8 to
7078030
Compare
Jimbo4350
requested changes
Apr 16, 2025
Contributor
There was a problem hiding this comment.
- No need for the
metavarchanges to be in this PR. Please remove them to a separate PR and open an ADR. - This needs to be addresses: #1079 (comment)
- Introduce online vs offline as pointed out in slack
Everything else looks good. Happy to approve after.
cardano-cli/test/cardano-cli-golden/files/golden/help/latest_genesis_create-staked.cli
Outdated
Show resolved
Hide resolved
7078030 to
c93a53a
Compare
25e013e to
299861f
Compare
Jimbo4350
requested changes
Apr 22, 2025
Jimbo4350
approved these changes
Apr 22, 2025
carbolymer
reviewed
Apr 23, 2025
carbolymer
reviewed
Apr 23, 2025
carbolymer
reviewed
Apr 23, 2025
cardano-cli/test/cardano-cli-test/Test/Cli/Transaction/Build.hs
Outdated
Show resolved
Hide resolved
Make `--out-file` optional Add support for eras before conway
- Split online and offline functionality into subcommands - Use point free style to improve code layout - Replace `evalEitherM` and `readJsonFile` with `readJsonFileOk` - Remove parametrisation on era Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
5e415e4 to
6e22c35
Compare
Already addressed issues and agreed the PR was ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR addresses this issue: #945
This PR depends on the following PR from
cardano-api, I would recommend looking at both in conjunction: IntersectMBO/cardano-api#771How to trust this PR
The test should provide some confidence, there is not a lot of change in the actual implementation, except that the parameters allow to provide the required info directly instead of querying the node.
Checklist