Skip to content

Cardano.Api.Experimental: Fix missing key witnesses in certificates #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carbolymer merged 2 commits into from
Jun 26, 2025
Merged

Cardano.Api.Experimental: Fix missing key witnesses in certificates #879

carbolymer merged 2 commits into from
Jun 26, 2025

Conversation

@carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jun 26, 2025 •
edited
Loading

Changelog

- description: |
    Cardano.Api.Experimental: Fix missing key witnesses in certificates
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Certificates were missing key witnesses when using experimental API.

This PR also adds Cardano.Api.Trace.Debug module which adds helper functions useful in debugging. Every time I've debugged cardano-cli or cardano-api I've spent some time adding those functions and pretty-simple dependency and removing them in the end. So the goal of this module is provide a ready to use debug module with pretty printing tracing functions. The functions added there are marked as DEPRECATED to avoid accidentally leaving them in the production code.

Related:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-missing-witness-in-certificates branch from 4bf4c1b to 001467b Compare June 26, 2025 17:59
@carbolymer carbolymer self-assigned this Jun 26, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-missing-witness-in-certificates branch from 001467b to 1d06d7c Compare June 26, 2025 18:15
Jimbo4350
Jimbo4350 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so this was my fault 😢 . Nice work 👍

@carbolymer carbolymer enabled auto-merge June 26, 2025 18:19
@carbolymer carbolymer added this pull request to the merge queue Jun 26, 2025
Merged via the queue into master with commit f0a7ddf Jun 26, 2025
27 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/fix-missing-witness-in-certificates branch June 26, 2025 18:42
@carbolymer carbolymer mentioned this pull request Jun 27, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@carbolymer carbolymer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carbolymer @Jimbo4350