Fixed PlayerGPS loading ContentReader maps before mods ready #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removed, which erroneously included disabled mods
Interkarma
approved these changes
Feb 6, 2024
numidium
approved these changes
Feb 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573 . Most of the details should be on the issue, but in summary:
Before the fix, this could happen before disabled mods were removed (this occurs in ModManager.Init). Now, PlayerGPS waits for the ModManager to be Initialized before running.
As an aside, for performance reasons, I'd like if ContentReader did not read all the regions on boot, since it slows down when mods try adding thousands of new locations (carademono has a vision, okay). But I'm not ready to change that yet - maybe I'll send cara a custom build to see if simply having independent caches per region works.
But this simple change fixes the issue, and increases performance when running disabled mods with WorldData.