Fix for Advanced Climbing bug #2560 #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bing. Moved "ClearStateOnRestore" to always run on restore, not just when climbing with Advanced
Collaborator
Author
|
Things not in the PR but I'm considering:
|
Owner
|
All good if you want to include the debug HUD or a flawless climbing cheat, either in this PR or separate PRs. Good point on low climb characters being disappointed with the fix. |
…ll systems. Only one debug panel on at a time
…e perfect climbing)
Collaborator
|
I tested this on my end. My character slips when doing long climbs as expected but if I stop mid-climb, move sideways, and continue moving in any direction then I can scale a building like a spider indefinitely without slipping. Not sure if this is intentional. |
numidium
approved these changes
Jan 22, 2024
Interkarma
approved these changes
Jan 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue at #2560
Fixed "overrideSkillCheck" not being turned off after being done Climbing.
overrideSkillCheck is used in the transition from wall to the floor above it, and should only be true during that automatic movement.
Moved "ClearStateOnRestore" to always run on restore, not just when climbing with Advanced.
The second fix is not strictly required, but seems cleaner. No risk of regression, since non-advanced climbing should have no expectation of state if saving/reloading during climbing (it's supposed to drop the moment you let the key go).