This looks like a rather large refactor just to fix an exception. I'd prefer to see fewer lines touched.

What's the actual issue being fixed here? If you can give me a repro save, I might like to handle this a different way.

Sorry, I could have explained better. Right now you will get exceptions thrown when either bashing a building interior door or dungeon exterior door. In addition, it doesn't transition the player through the door.

I'm letting ActivateStaticDoor handle the static door transitions for bashing since most of the logic is already there. I added a little extra logic to handle bashing but github's diffing went a little wild. If you look at what was "removed" vs what was "added" it is largely the same with a few exceptions (at least in the case of ActivateStaticDoor).

I zipped a couple of saves with a character standing next to doors that will yield exceptions when you bash them.
Saves.zip

Thank you for save. I'll look into the issue when I can. :)

This error is still being hit by users. After fixing the public API changes, I'd be willing to merge this

There was one public method that I renamed. Its name is now reverted to what it was originally per Kab's request.

After having run tests, the changelist mostly works as advertised, outside the Open issue I've mentioned.

I've run tests on classic DF, and here's what I've concluded from bashing doors:

• Trying to bash the exterior door from the inside causes you to warp inside as if you'd just broken in from the outside, with possibility of guards. I'm fine with the approach this PR takes instead
• Trying to bash internal doors always succeeds if they are unlocked, and will not trigger guards, not even in a dungeon palace like Wayrest. The sound is not bash, but just a normal open
• Dungeon doors are not bashable, not even a sound

I'm fine with DFU diverging on point 1 and 3. I know this changelist is about external doors, but while we're on it, I think we should update DaggerfallActionDoor.AttemptBash to 1) always open door if the lock value is 0 2) not make enemies hostile if the lock value is 0. Note that closing the door currently behaves properly, save for the alerting enemies part.

Summary of my recommandations:

Must:

• Fix so that Open is not consumed when bashing

Nice to have:

• Bit of cleanup around isBash checks
• Remove the Greeting for Open
• Bashing both external and interior doors should always work if the door has no lock
• Bashing unlocked interior doors should not make Palace guards hostile (see Wayrest). Bashing locked interior doors should still always alert (see Daggerfall)

OK, should be ready for merging now.