Fix bug on PMGDQueryHandler which locks the graph#4
Closed
Conversation
vishakha041
reviewed
Feb 27, 2018
| throw e; | ||
| } | ||
|
|
||
| if (retval < 0) { |
Contributor
There was a problem hiding this comment.
This is not needed here. It can go in the error_cleanup function since we already call it on error return.
Contributor
Author
There was a problem hiding this comment.
Adding this to error_cleanup won't work. error_cleanup can be called after unlocking _dblock, std::mutex has undefined behavior if you unlock a lock twice.
The safe place to unlock is the same function we lock ( process_query(2) ).
Contributor
|
I have a separate fix based on Philip's input too. Will create a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMGDQueryHandler hangs when there is a fail command. This fixed the problem, but @vishakha041 please check if this is the right way to handle it.