Enable pre-commit for formatting and linting#267
Conversation
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
…point to pre-commit instructions
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
rolandoquesada
left a comment
There was a problem hiding this comment.
The changes look good to me.
I like that this format tool also removes unused variables and imported/included libraries.
Closes #266
The following were performed in this PR:
Manually modified files:
Remaining files were modified after applying hooks
After this is merged, users can manually setup to apply to all commits:
But as a safe-guard, it is also included in the CI process. In cases where changes are needed, the CI job will fail. If pre-commit can automatically fix issues, the CI will restart with new changes. If pre-commit cannot fix any issues, user should fix requested issues and CI will start once PR is updated.