Conversation
…-search-parameters-of-all-the-vcl-indices
…-search-parameters-of-all-the-vcl-indices
Contributor
|
Target CPP Coverage: 64.1421% Target Python Coverage: 97.94% |
cwlacewe
reviewed
Feb 27, 2025
Contributor
cwlacewe
left a comment
There was a problem hiding this comment.
Looks good but can you remove the old commands (commented out) in the unit test files.
Comment on lines
+105
to
+106
| // FaissIVFFlatDescriptorSet(const std::string &set_path, unsigned dim, | ||
| // DistanceMetric metric); |
Contributor
There was a problem hiding this comment.
Suggested change
| // FaissIVFFlatDescriptorSet(const std::string &set_path, unsigned dim, | |
| // DistanceMetric metric); |
Contributor
Author
There was a problem hiding this comment.
Updated the test files and removed a lot of comments that are not needed.
Comment on lines
+116
to
+117
| // FaissHNSWFlatDescriptorSet(const std::string &set_path, unsigned | ||
| // dim,DistanceMetric metric); |
Contributor
There was a problem hiding this comment.
Suggested change
| // FaissHNSWFlatDescriptorSet(const std::string &set_path, unsigned | |
| // dim,DistanceMetric metric); |
|
|
||
| VCL::DescriptorParams *param = new VCL::DescriptorParams(3, nb / 10, 10, 12,2,6,16,64,96,48); | ||
| VCL::DescriptorSet index(index_filename, unsigned(d), eng, VCL::DistanceMetric::L2, param); | ||
| //VCL::DescriptorSet index(index_filename, unsigned(d), eng); |
Contributor
There was a problem hiding this comment.
Suggested change
| //VCL::DescriptorSet index(index_filename, unsigned(d), eng); |
Contributor
There was a problem hiding this comment.
Please remove commented lines of previous command in remainder of file
Contributor
|
Closes #225 |
…-search-parameters-of-all-the-vcl-indices
Contributor
|
Target CPP Coverage: 64.1323% Target Python Coverage: 97.94% |
cwlacewe
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.